[
https://issues.apache.org/jira/browse/DRILL-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608546#comment-17608546
]
ASF GitHub Bot commented on DRILL-8317:
---------------------------------------
jnturton commented on code in PR #2659:
URL: https://github.com/apache/drill/pull/2659#discussion_r978279426
##########
contrib/format-log/src/main/java/org/apache/drill/exec/store/log/LogBatchReader.java:
##########
@@ -215,18 +208,14 @@ public boolean next() {
}
private boolean nextLine(RowSetLoader rowWriter) {
- if (rowWriter.limitReached(maxRecords)) {
Review Comment:
Review note: this goes away because it's handled by EVF now.
> Convert LogRegex Format Plugin to EVF V2
> ----------------------------------------
>
> Key: DRILL-8317
> URL: https://issues.apache.org/jira/browse/DRILL-8317
> Project: Apache Drill
> Issue Type: Task
> Components: Format - Log Reader
> Affects Versions: 1.20.2
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 2.0.0
>
>
> Converts the existing logRegex reader to EVF V2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
