[
https://issues.apache.org/jira/browse/DRILL-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633868#comment-17633868
]
ASF GitHub Bot commented on DRILL-8357:
---------------------------------------
cgivre commented on PR #2705:
URL: https://github.com/apache/drill/pull/2705#issuecomment-1313908517
@jnturton The PR looks good. I had a few questions:
1. Could you please document what types of input would be expected in
these fields and what they do? I'm not really clear myself what the `owner`
field actually does. If you're not sure, then let's leave it, but if you had
some additional info, that would be helpful.
2. I had question about the `token` and `cookie`? Are these fields
something that we'd expect to be set in a config, or are they something that
should be somehow populated dynamically? This seemed strange to me.
> Add new config options to the Splunk storage plugin
> ---------------------------------------------------
>
> Key: DRILL-8357
> URL: https://issues.apache.org/jira/browse/DRILL-8357
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.20.2
> Reporter: James Turton
> Assignee: James Turton
> Priority: Minor
> Fix For: 2.0.0
>
>
> The following five new options can be added to the Splunk storage config.
> {code:java}
> // Whether the Splunk client will validates the server's SSL cert.
> private final boolean validateCertificates;
> // The application context of the service.
> private final String app;
> // The owner context of the service.
> private final String owner;
> // A Splunk authentication token to use for the session.
> private final String token;
> // A valid login cookie.
> private final String cookie;{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
