[ 
https://issues.apache.org/jira/browse/DRILL-8380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675816#comment-17675816
 ] 

ASF GitHub Bot commented on DRILL-8380:
---------------------------------------

jnturton commented on code in PR #2733:
URL: https://github.com/apache/drill/pull/2733#discussion_r1067718395


##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java:
##########
@@ -403,8 +404,24 @@ private View getView(DotDrillFile f) throws IOException {
       return f.getView(mapper);
     }
 
+    private String getTemporaryName(String name) {
+      if (isTemporaryWorkspace()) {
+        String tableName = DrillStringUtils.removeLeadingSlash(name);
+        return schemaConfig.getTemporaryTableName(tableName);
+      }
+      return null;
+    }
+
+    private boolean isTemporaryWorkspace() {

Review Comment:
   Could this utility method move to SchemaConfig or SchemaUtilities so that 
it's available for reuse elsewhere or is that unlikely?





> Remove customised SqlValidatorImpl.deriveAlias
> ----------------------------------------------
>
>                 Key: DRILL-8380
>                 URL: https://issues.apache.org/jira/browse/DRILL-8380
>             Project: Apache Drill
>          Issue Type: Sub-task
>            Reporter: Vova Vysotskyi
>            Assignee: Vova Vysotskyi
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to