[
https://issues.apache.org/jira/browse/DRILL-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685159#comment-17685159
]
ASF GitHub Bot commented on DRILL-8379:
---------------------------------------
jnturton commented on code in PR #2749:
URL: https://github.com/apache/drill/pull/2749#discussion_r1098367575
##########
exec/java-exec/src/main/codegen/data/Parser.tdd:
##########
@@ -118,780 +118,824 @@
# List of keywords from "keywords" section that are not reserved.
# Copied from calcite-core config.fmpp
# For details please see comment under CALCITE-2405.
- nonReservedKeywords: [
- "A"
- "ABSENT"
- "ABSOLUTE"
- "ACTION"
- "ADA"
- "ADD"
- "ADMIN"
- "AFTER"
- "ALIAS"
- "ALIASES"
- "ALWAYS"
- "APPLY"
- "ASC"
- "ASSERTION"
- "ASSIGNMENT"
- "ATTRIBUTE"
- "ATTRIBUTES"
- "BEFORE"
- "BERNOULLI"
- "BREADTH"
- "C"
- "CASCADE"
- "CATALOG"
- "CATALOG_NAME"
- "CENTURY"
- "CHAIN"
- "CHARACTER_SET_CATALOG"
- "CHARACTER_SET_NAME"
- "CHARACTER_SET_SCHEMA"
- "CHARACTERISTICS"
- "CHARACTERS"
- "CLASS_ORIGIN"
- "COBOL"
- "COLLATION"
- "COLLATION_CATALOG"
- "COLLATION_NAME"
- "COLLATION_SCHEMA"
- "COLUMN_NAME"
- "COMMAND_FUNCTION"
- "COMMAND_FUNCTION_CODE"
- "COMMITTED"
- "CONDITION_NUMBER"
- "CONNECTION"
- "CONNECTION_NAME"
- "CONSTRAINT_CATALOG"
- "CONSTRAINT_NAME"
- "CONSTRAINT_SCHEMA"
- "CONSTRAINTS"
- "CONSTRUCTOR"
- "CONTINUE"
- "CURSOR_NAME"
- "DATA"
- "DATABASE"
- "DATETIME_INTERVAL_CODE"
- "DATETIME_INTERVAL_PRECISION"
- "DECADE"
- "DEFAULTS"
- "DEFERRABLE"
- "DEFERRED"
- "DEFINED"
- "DEFINER"
- "DEGREE"
- "DEPTH"
- "DERIVED"
- "DESC"
- "DESCRIPTION"
- "DESCRIPTOR"
- "DIAGNOSTICS"
- "DISPATCH"
- "DOMAIN"
- "DOW"
- "DOY"
- "DYNAMIC_FUNCTION"
- "DYNAMIC_FUNCTION_CODE"
- "ENCODING"
- "EPOCH"
- "ERROR"
- "EXCEPTION"
- "EXCLUDE"
- "EXCLUDING"
- "FINAL"
- "FIRST"
- "FOLLOWING"
- "FORMAT"
- "FORTRAN"
- "FOUND"
- "FRAC_SECOND"
- "G"
- "GENERAL"
- "GENERATED"
- "GEOMETRY"
- "GO"
- "GOTO"
- "GRANTED"
- "HIERARCHY"
- "IMMEDIATE"
- "IMMEDIATELY"
- "IMPLEMENTATION"
- "INCLUDING"
- "INCREMENT"
- "INITIALLY"
- "INPUT"
- "INSTANCE"
- "INSTANTIABLE"
- "INVOKER"
- "ISODOW"
- "ISOYEAR"
- "ISOLATION"
- "JAVA"
- "JSON"
- "K"
- "KEY"
- "KEY_MEMBER"
- "KEY_TYPE"
- "LABEL"
- "LAST"
- "LENGTH"
- "LEVEL"
- "LIBRARY"
- "LOCATOR"
- "M"
- "MAP"
- "MATCHED"
- "MAXVALUE"
- "MICROSECOND"
- "MESSAGE_LENGTH"
- "MESSAGE_OCTET_LENGTH"
- "MESSAGE_TEXT"
- "MILLISECOND"
- "MILLENNIUM"
- "MINVALUE"
- "MONTHS"
- "MORE_"
- "MUMPS"
- "NAME"
- "NAMES"
- "NANOSECOND"
- "NESTING"
- "NORMALIZED"
- "NULLABLE"
- "NULLS"
- "NUMBER"
- "OBJECT"
- "OCTETS"
- "OPTION"
- "OPTIONS"
- "ORDERING"
- "ORDINALITY"
- "OTHERS"
- "OUTPUT"
- "OVERRIDING"
- "PAD"
- "PARAMETER_MODE"
- "PARAMETER_NAME"
- "PARAMETER_ORDINAL_POSITION"
- "PARAMETER_SPECIFIC_CATALOG"
- "PARAMETER_SPECIFIC_NAME"
- "PARAMETER_SPECIFIC_SCHEMA"
- "PARTIAL"
- "PASCAL"
- "PASSING"
- "PASSTHROUGH"
- "PAST"
- "PATH"
- "PLACING"
- "PLAN"
- "PLI"
- "PRECEDING"
- "PRESERVE"
- "PRIOR"
- "PRIVILEGES"
- "PUBLIC"
- "QUARTER"
- "READ"
- "RELATIVE"
- "REPEATABLE"
- "REPLACE"
- "RESTART"
- "RESTRICT"
- "RETURNED_CARDINALITY"
- "RETURNED_LENGTH"
- "RETURNED_OCTET_LENGTH"
- "RETURNED_SQLSTATE"
- "ROLE"
- "ROUTINE"
- "ROUTINE_CATALOG"
- "ROUTINE_NAME"
- "ROUTINE_SCHEMA"
- "ROW_COUNT"
- "SCALE"
- "SCHEMA"
- "SCHEMA_NAME"
- "SCOPE_CATALOGS"
- "SCOPE_NAME"
- "SCOPE_SCHEMA"
- "SECTION"
- "SECURITY"
- "SELF"
- "SEQUENCE"
- "SERIALIZABLE"
- "SERVER"
- "SERVER_NAME"
- "SESSION"
- "SETS"
- "SIMPLE"
- "SIZE"
- "SOURCE"
- "SPACE"
- "SPECIFIC_NAME"
- "SQL_BIGINT"
- "SQL_BINARY"
- "SQL_BIT"
- "SQL_BLOB"
- "SQL_BOOLEAN"
- "SQL_CHAR"
- "SQL_CLOB"
- "SQL_DATE"
- "SQL_DECIMAL"
- "SQL_DOUBLE"
- "SQL_FLOAT"
- "SQL_INTEGER"
- "SQL_INTERVAL_DAY"
- "SQL_INTERVAL_DAY_TO_HOUR"
- "SQL_INTERVAL_DAY_TO_MINUTE"
- "SQL_INTERVAL_DAY_TO_SECOND"
- "SQL_INTERVAL_HOUR"
- "SQL_INTERVAL_HOUR_TO_MINUTE"
- "SQL_INTERVAL_HOUR_TO_SECOND"
- "SQL_INTERVAL_MINUTE"
- "SQL_INTERVAL_MINUTE_TO_SECOND"
- "SQL_INTERVAL_MONTH"
- "SQL_INTERVAL_SECOND"
- "SQL_INTERVAL_YEAR"
- "SQL_INTERVAL_YEAR_TO_MONTH"
- "SQL_LONGVARBINARY"
- "SQL_LONGVARNCHAR"
- "SQL_LONGVARCHAR"
- "SQL_NCHAR"
- "SQL_NCLOB"
- "SQL_NUMERIC"
- "SQL_NVARCHAR"
- "SQL_REAL"
- "SQL_SMALLINT"
- "SQL_TIME"
- "SQL_TIMESTAMP"
- "SQL_TINYINT"
- "SQL_TSI_DAY"
- "SQL_TSI_FRAC_SECOND"
- "SQL_TSI_HOUR"
- "SQL_TSI_MICROSECOND"
- "SQL_TSI_MINUTE"
- "SQL_TSI_MONTH"
- "SQL_TSI_QUARTER"
- "SQL_TSI_SECOND"
- "SQL_TSI_WEEK"
- "SQL_TSI_YEAR"
- "SQL_VARBINARY"
- "SQL_VARCHAR"
- "STATE"
- "STATEMENT"
- "STORAGE"
- "STRUCTURE"
- "STYLE"
- "SUBCLASS_ORIGIN"
- "SUBSTITUTE"
- "TABLE_NAME"
- "TEMPORARY"
- "TIES"
- "TIMESTAMPADD"
- "TIMESTAMPDIFF"
- "TOP_LEVEL_COUNT"
- "TRANSACTION"
- "TRANSACTIONS_ACTIVE"
- "TRANSACTIONS_COMMITTED"
- "TRANSACTIONS_ROLLED_BACK"
- "TRANSFORM"
- "TRANSFORMS"
- "TRIGGER_CATALOG"
- "TRIGGER_NAME"
- "TRIGGER_SCHEMA"
- "TYPE"
- "UNBOUNDED"
- "UNCOMMITTED"
- "UNDER"
- "UNNAMED"
- "USAGE"
- "USER_DEFINED_TYPE_CATALOG"
- "USER_DEFINED_TYPE_CODE"
- "USER_DEFINED_TYPE_NAME"
- "USER_DEFINED_TYPE_SCHEMA"
- "VERSION"
- "VIEW"
- "WEEK"
- "WRAPPER"
- "WORK"
- "WRITE"
- "XML"
- "ZONE"
+ nonReservedKeywords: [
Review Comment:
Do the updates to these lists comes from some corresponding lists that were
updated in Calcite?
> Update Calcite to 1.33.0
> ------------------------
>
> Key: DRILL-8379
> URL: https://issues.apache.org/jira/browse/DRILL-8379
> Project: Apache Drill
> Issue Type: Task
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)