[ https://issues.apache.org/jira/browse/DRILL-8402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691724#comment-17691724 ]
ASF GitHub Bot commented on DRILL-8402: --------------------------------------- cgivre commented on PR #2762: URL: https://github.com/apache/drill/pull/2762#issuecomment-1438871668 > Wouldn't this change introduce ReDoS vulnerability? Potentially, but we already allow `REGEXP_REPLACE` and `REGEX_MATCHES`, so I don't know that this actually makes anything worse. I did try adding a validator with this `saferegex`[1] but that library is not suitable for inclusion in Drill. (It prints all kinds of stuff to STDOUT.) [1]: https://github.com/jkutner/saferegex > Add REGEXP_EXTRACT Function > --------------------------- > > Key: DRILL-8402 > URL: https://issues.apache.org/jira/browse/DRILL-8402 > Project: Apache Drill > Issue Type: Improvement > Components: Functions - Drill > Affects Versions: 1.21.0 > Reporter: Charles Givre > Assignee: Charles Givre > Priority: Major > Fix For: 1.21.1 > > > This PR adds two UDFs to Drill: > regexp_extract(<text>, <pattern>) which returns an array of strings which > were captured by capturing groups in the regex. > regexp_extract(<text>, <pattern>, <index>) returns the text captured by a > specific capturing group. -- This message was sent by Atlassian Jira (v8.20.10#820010)