[
https://issues.apache.org/jira/browse/DRILL-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700673#comment-17700673
]
ASF GitHub Bot commented on DRILL-8410:
---------------------------------------
jnturton opened a new pull request, #2775:
URL: https://github.com/apache/drill/pull/2775
# [DRILL-8410](https://issues.apache.org/jira/browse/DRILL-8410): Upgrade to
Calcite 1.34
## Description
Calcite 1.34 includes
1.a fix for the currently broken date_trunc function in Drill
2. support for a new QUALIFY clause in windows functions
3. incompatible core parser grammar changes that break date_diff in Drill.
Because of (3), Drill needs to make temporary use of a modified Parser.jj
until Calcite backs out the mentioned parser changes. See the linked Calcite
issues for more details.
Normally it would be undesirable to backport the new QUALIFY clause but,
short of setting up cherry picking from Calcite, getting the fix for the
regression in DATE_TRUNC forces the addition of support for QUALIFY. Calcite
does not do seperate bugfix releases.
## Documentation
Document the new QUALIFY clause.
## Testing
- Existing unit tests of DATE_TRUNC.
- Existing unit tests of DATE_DIFF.
- New unit test of QUALIFY.
> Upgrade to Calcite 1.34
> -----------------------
>
> Key: DRILL-8410
> URL: https://issues.apache.org/jira/browse/DRILL-8410
> Project: Apache Drill
> Issue Type: Improvement
> Components: library
> Affects Versions: 1.21.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 1.21.1
>
>
> Calcite 1.34 includes
> # a fix for the currently broken date_trunc function in Drill
> # support for a new QUALIFY clause in windows functions
> # incompatible core parser grammar changes that break date_diff in Drill.
> Because of (3), Drill needs to make temporary use of a modified Parser.jj
> until Calcite backs out the mentioned parser changes. See the linked Calcite
> issues for more details.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
