[
https://issues.apache.org/jira/browse/DRILL-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713137#comment-17713137
]
ASF GitHub Bot commented on DRILL-8424:
---------------------------------------
jnturton commented on code in PR #2794:
URL: https://github.com/apache/drill/pull/2794#discussion_r1168863776
##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/conversion/DrillRexBuilder.java:
##########
@@ -65,9 +65,9 @@ public RexNode ensureType(
* @return Call to CAST operator
*/
@Override
- public RexNode makeCast(RelDataType type, RexNode exp, boolean
matchNullability) {
+ public RexNode makeCast(RelDataType type, RexNode exp, boolean
matchNullability, boolean safe) {
Review Comment:
They did do this and only deprecated the original method so our build wasn't
broken but our subclass DrillRexBuilder was broken in terms of runtime logic
because our method override no longer took effect when it needed to.
> Accommodate RexBuilder changes made for SAFE_CAST
> -------------------------------------------------
>
> Key: DRILL-8424
> URL: https://issues.apache.org/jira/browse/DRILL-8424
> Project: Apache Drill
> Issue Type: Improvement
> Components: Query Planning & Optimization
> Affects Versions: 1.22.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 1.22.0
>
>
> The introduction of SAFE_CAST support in CALCITE-5575 made method signature
> changes in RexBuilder that broke a needed override in DrillRexBuilder.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
