[ https://issues.apache.org/jira/browse/DRILL-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724670#comment-17724670 ]
ASF GitHub Bot commented on DRILL-8158: --------------------------------------- hboutemy commented on code in PR #2805: URL: https://github.com/apache/drill/pull/2805#discussion_r1199775459 ########## pom.xml: ########## @@ -562,7 +562,6 @@ <includeOnlyProperty>^git\.commit\..*$</includeOnlyProperty> <includeOnlyProperty>^git\.dirty$</includeOnlyProperty> <includeOnlyProperty>^git\.tags$</includeOnlyProperty> - <includeOnlyProperty>^git\.total\.commit\.count$</includeOnlyProperty> Review Comment: in fact, if you do a shallow git clone, you get 1 instead of the value of the full content: yes, not so easy to guess :) > Remove non-reproducible build outputs > ------------------------------------- > > Key: DRILL-8158 > URL: https://issues.apache.org/jira/browse/DRILL-8158 > Project: Apache Drill > Issue Type: Bug > Affects Versions: 1.20.0 > Reporter: Herve Boutemy > Assignee: James Turton > Priority: Major > Fix For: 1.20.2 > > > For context see [1] and [2]. The git-commit-id plugin includes information > like build host, email and time which is not compatible with a reproducible > build. Drill's built in sys.version table will return the build email and > time if they are present in the build's git.properties file so these columns > must be deprecated. Other useful Git-related information is retained. > In accompanying commits, some Kerberos unit test fixes are applied, and the > tests reenabled, and some updates to Release.md are included. > [1] [https://maven.apache.org/guides/mini/guide-reproducible-builds.html] > [2] > [https://github.com/jvm-repo-rebuild/reproducible-central#org.apache.drill:drill-root] -- This message was sent by Atlassian Jira (v8.20.10#820010)