[jira] [Commented] (DRILL-8451) options and profile pages have bad order symbols style

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/DRILL-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752401#comment-17752401
 ] 

ASF GitHub Bot commented on DRILL-8451:
---------------------------------------

rymarm opened a new pull request, #2820:
URL: https://github.com/apache/drill/pull/2820

   # [DRILL-8451](https://issues.apache.org/jira/browse/DRILL-8451): options 
and profile pages have bad order symbols style
   
   ## Description
   
   "Options" and "Profile" pages have bad order symbols style:
   
   Current:
   
![зображення](https://github.com/apache/drill/assets/62295633/741f39a0-a2b1-4fe6-aaa4-6b5cbd75ee67)
   
![зображення](https://github.com/apache/drill/assets/62295633/e48f5a67-380b-40a6-8e19-538334db1a6f)
   
   Expected:
   
![зображення](https://github.com/apache/drill/assets/62295633/cd210e24-01b6-4f8d-a9d1-34073cdeb438)
   
   
   "Options" and "Profile" pages were using Drill own sorting symbols styling 
instead of dataTables style that is used on all other pages. I've removed 
outdated `black-asc.gif`, `black-dsc.gif`, `black-unsorted.gif` sorting 
symbols, and replaced them with dataTable styled symbols. 
   
   I also disabled sorting for "value" and "description" columns on "Options" 
page. Sorting on "value" doesn't work properly due to different types of 
values, and sorting on the "description" column is just redundant.
   
   ### Options page
   before:
   
![зображення](https://github.com/apache/drill/assets/62295633/bc663fe9-35d0-4e5a-ad45-f1732b58ff6d)
   
   after:
   
![зображення](https://github.com/apache/drill/assets/62295633/9262b016-ad63-4a06-9cd9-3f6d072453b2)
   
   
   ### Profile page
   before:
   
![зображення](https://github.com/apache/drill/assets/62295633/f8e43a40-de6b-41be-972a-b667a8a812ef)
   
   after:
   
![зображення](https://github.com/apache/drill/assets/62295633/0715e7c6-1a23-4b77-9891-f614edbf49de)
   
   
   ## Documentation
   None requerid
   
   ## Testing
   Visual check of UI in Firefox and Edge browsers.
   




> options and profile pages have bad order symbols style
> ------------------------------------------------------
>
>                 Key: DRILL-8451
>                 URL: https://issues.apache.org/jira/browse/DRILL-8451
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.16.0
>            Reporter: Maksym Rymar
>            Assignee: Maksym Rymar
>            Priority: Minor
>             Fix For: 1.22.0
>
>         Attachments: image-2023-08-09-13-16-56-687.png, 
> image-2023-08-09-13-18-28-574.png, image-2023-08-09-13-19-41-196.png
>
>
> "Options" and "Profile" pages have bad order symbols style:
> Current:
> !image-2023-08-09-13-16-56-687.png!
> !image-2023-08-09-13-18-28-574.png!
> Expected:
> !image-2023-08-09-13-19-41-196.png!
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)