[
https://issues.apache.org/jira/browse/DRILL-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949980#comment-17949980
]
ASF GitHub Bot commented on DRILL-8523:
---------------------------------------
jnturton commented on code in PR #2987:
URL: https://github.com/apache/drill/pull/2987#discussion_r2076801836
##########
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestNestedDateTimeTimestamp.java:
##########
@@ -46,6 +48,13 @@ public class TestNestedDateTimeTimestamp extends
BaseTestQuery {
private static final String DATAFILE =
"cp.`datetime.parquet`";
private static final Map<String, Object> expectedRecord = new
TreeMap<String, Object>();
+ @BeforeClass
+ public static void setUpTimeZone() {
Review Comment:
I think this could go in separately, accompanied by an excplicit decision
that running the test suite (even Drill itself?) is unsupported outside of UTC?
I personally think things should still basically work on machines in different
time zones. I know these don't work today, but maybe it _should_ and what's
really wanted is a fix, while this make the symptoms disappear.
I've got `-Djunit.args="-Duser.timezone=UTC"` in my local `mvn test`
invocations in the meantime
##########
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassTransformer.java:
##########
@@ -307,26 +288,38 @@ public Class<?> getImplementationClass(
s = s.replace(DrillFileUtils.SEPARATOR_CHAR, '.');
names.add(nextSet.getChild(s));
}
- classLoader.injectByteCode(nextGenerated.dot, result.bytes);
+
+ // Only inject bytecode if not already injected
+ if (!injectedClassNames.contains(nextGenerated.dot)) {
Review Comment:
It's hard to tell from the diff what was broken here before. Was the
`namesCompleted` Set not enough to keep track of classes that had already been
merged?
> Remove Support for Java 8
> -------------------------
>
> Key: DRILL-8523
> URL: https://issues.apache.org/jira/browse/DRILL-8523
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.21.2
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.22.0
>
>
> This PR removes CI actions for Hadoop 2 and Java 8.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
