[
https://issues.apache.org/jira/browse/DRILL-8527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17987938#comment-17987938
]
ASF GitHub Bot commented on DRILL-8527:
---------------------------------------
shfshihuafeng commented on PR #2997:
URL: https://github.com/apache/drill/pull/2997#issuecomment-3028463550
> > @shfshihuafeng Regarding the unit tests, they really don't have to be
complicated. You can use the example below as a template, but basically, we
just want to make sure that the correct limit is being pushed into the query
plan. I'd include a query with a limit set and another with an `OFFSET`. Same
goes for the filter pushdown. It shouldn't be much work.
> >
https://github.com/apache/drill/blob/b4dd73875ee3e6932f91fdee56e6692a48a06cb4/contrib/format-httpd/src/test/java/org/apache/drill/exec/store/httpd/TestHTTPDLogReader.java#L141-#L150
>
> @cgivre Thank you for your case . I have finished unit tests for this pr,
but When I run this unit tests with jdk17, I found that it couldn't be executed
When I use a JDK greater than 1.8(such as JDK17), if the test cases inherit
HiveTestBase, those test cases couldn't be executed, like the following . this
week I have a lot of work to do, so I haven't dealt with this problem yet. I
can complete it next week, including unit testing for another PR
>
> ```
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
5.296 s
> Hive Limit Push Down
> --------------------
>
> Key: DRILL-8527
> URL: https://issues.apache.org/jira/browse/DRILL-8527
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Hive
> Affects Versions: 1.22.0
> Reporter: shihuafeng
> Priority: Major
> Fix For: 1.23.0
>
> Attachments: image-2025-07-01-20-13-15-175.png,
> image-2025-07-01-20-14-31-627.png, image-2025-07-01-20-15-26-235.png
>
>
> Support hive limit push down。i test the same sql
> sql :select * from hive.testorc limit 2
> data size :5001
> data file : file1:1 row file: 5000
> *Before limit push down*
> !image-2025-07-01-20-14-31-627.png!
> *After limit push down*
> !image-2025-07-01-20-15-26-235.png!
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
