[
https://issues.apache.org/jira/browse/DRILL-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057116#comment-18057116
]
ASF GitHub Bot commented on DRILL-8543:
---------------------------------------
cgivre commented on code in PR #3036:
URL: https://github.com/apache/drill/pull/3036#discussion_r2778456519
##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/MaterializedViewHandler.java:
##########
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.sql.handlers;
+
+import java.io.IOException;
+
+import org.apache.calcite.plan.RelTraitSet;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.schema.Schema;
+import org.apache.calcite.schema.SchemaPlus;
+import org.apache.calcite.schema.Table;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.tools.RelConversionException;
+import org.apache.calcite.tools.ValidationException;
+import org.apache.drill.common.exceptions.UserException;
+import org.apache.drill.common.util.DrillStringUtils;
+import org.apache.drill.exec.dotdrill.MaterializedView;
+import org.apache.drill.exec.ops.QueryContext;
+import org.apache.drill.exec.physical.PhysicalPlan;
+import org.apache.drill.exec.physical.base.PhysicalOperator;
+import org.apache.drill.exec.planner.logical.CreateTableEntry;
+import org.apache.drill.exec.planner.logical.DrillRel;
+import org.apache.drill.exec.planner.logical.DrillScreenRel;
+import org.apache.drill.exec.planner.logical.DrillWriterRel;
+import org.apache.drill.exec.planner.physical.Prel;
+import org.apache.drill.exec.planner.sql.DirectPlan;
+import org.apache.drill.exec.planner.sql.SchemaUtilities;
+import org.apache.drill.exec.planner.sql.parser.SqlCreateMaterializedView;
+import org.apache.drill.exec.planner.sql.parser.SqlCreateType;
+import org.apache.drill.exec.planner.sql.parser.SqlDropMaterializedView;
+import org.apache.drill.exec.planner.sql.parser.SqlRefreshMaterializedView;
+import org.apache.drill.exec.store.AbstractSchema;
+import org.apache.drill.exec.work.foreman.ForemanSetupException;
+import org.apache.drill.exec.work.foreman.SqlUnsupportedException;
+
+/**
+ * Handlers for materialized view DDL commands: CREATE, DROP, and REFRESH
MATERIALIZED VIEW.
+ * <p>
+ * CREATE and DROP return DirectPlan with ok/summary output.
+ * REFRESH executes the MV query and writes data to Parquet, returning write
statistics.
+ */
+public abstract class MaterializedViewHandler extends DefaultSqlHandler {
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(MaterializedViewHandler.class);
+
+ protected QueryContext context;
+
+ public MaterializedViewHandler(SqlHandlerConfig config) {
+ super(config);
+ this.context = config.getContext();
+ }
+
+ /**
+ * Handler for CREATE MATERIALIZED VIEW DDL command.
+ * <p>
+ * Creates the MV definition file. The data will be materialized on first
query
+ * or can be explicitly populated via REFRESH MATERIALIZED VIEW.
+ */
+ public static class CreateMaterializedView extends MaterializedViewHandler {
+
+ public CreateMaterializedView(SqlHandlerConfig config) {
+ super(config);
+ }
+
+ @Override
+ public PhysicalPlan getPlan(SqlNode sqlNode) throws ValidationException,
RelConversionException,
+ IOException, ForemanSetupException {
+ SqlCreateMaterializedView createMV = unwrap(sqlNode,
SqlCreateMaterializedView.class);
+
+ final String newViewName =
DrillStringUtils.removeLeadingSlash(createMV.getName());
+
+ // Disallow temporary tables usage in materialized view definition
+ config.getConverter().disallowTemporaryTables();
+
+ // Store the SQL as the view definition
+ final String viewSql = createMV.getQuery().toSqlString(null,
true).getSql();
+ final ConvertedRelNode convertedRelNode =
validateAndConvert(createMV.getQuery());
+ final RelDataType validatedRowType =
convertedRelNode.getValidatedRowType();
+ final RelNode queryRelNode = convertedRelNode.getConvertedNode();
+
+ final RelNode newViewRelNode = SqlHandlerUtil.resolveNewTableRel(true,
createMV.getFieldNames(),
+ validatedRowType, queryRelNode);
+
+ final SchemaPlus defaultSchema = context.getNewDefaultSchema();
+ final AbstractSchema drillSchema =
SchemaUtilities.resolveToMutableDrillSchema(defaultSchema,
+ createMV.getSchemaPath());
+
+ final String schemaPath = drillSchema.getFullSchemaName();
+
+ // Check view creation possibility
+ if (!checkMaterializedViewCreationPossibility(drillSchema, createMV,
context)) {
+ return DirectPlan.createDirectPlan(context, false,
+ String.format("A table or view with given name [%s] already exists
in schema [%s]",
+ newViewName, schemaPath));
+ }
+
+ // Create the materialized view definition
+ // Use the actual schema path where the MV is created (not the session's
default schema)
+ final MaterializedView materializedView = new
MaterializedView(newViewName, viewSql,
+ newViewRelNode.getRowType(), drillSchema.getSchemaPath());
+
+ // Create the materialized view definition file
+ final boolean replaced =
drillSchema.createMaterializedView(materializedView);
+
+ String message = replaced
+ ? String.format("Materialized view '%s' replaced successfully in
'%s' schema", newViewName, schemaPath)
+ : String.format("Materialized view '%s' created successfully in '%s'
schema", newViewName, schemaPath);
+
+ logger.info("Created materialized view [{}] in schema [{}]",
newViewName, schemaPath);
+ return DirectPlan.createDirectPlan(context, true, message);
+ }
+
+ /**
+ * Validates if materialized view can be created in indicated schema.
+ */
+ private boolean checkMaterializedViewCreationPossibility(AbstractSchema
drillSchema,
+
SqlCreateMaterializedView createMV,
+ QueryContext
context) {
+ final String schemaPath = drillSchema.getFullSchemaName();
+ final String viewName = createMV.getName();
+ final Table table = SqlHandlerUtil.getTableFromSchema(drillSchema,
viewName);
+
+ // Check if it's a materialized view
+ final boolean isMaterializedView = table != null &&
+ table.getJdbcTableType() == Schema.TableType.MATERIALIZED_VIEW;
+ final boolean isView = (table != null && table.getJdbcTableType() ==
Schema.TableType.VIEW);
+ // Regular table check excludes views and materialized views
+ final boolean isTable = (table != null
+ && table.getJdbcTableType() != Schema.TableType.VIEW
+ && table.getJdbcTableType() != Schema.TableType.MATERIALIZED_VIEW)
+ || context.getSession().isTemporaryTable(drillSchema,
context.getConfig(), viewName);
+
+ SqlCreateType createType = createMV.getSqlCreateType();
+ switch (createType) {
+ case SIMPLE:
+ if (isTable) {
+ throw UserException.validationError()
+ .message("A non-view table with given name [%s] already exists
in schema [%s]",
+ viewName, schemaPath)
+ .build(logger);
+ } else if (isView) {
+ throw UserException.validationError()
+ .message("A view with given name [%s] already exists in schema
[%s]", viewName, schemaPath)
+ .build(logger);
+ } else if (isMaterializedView) {
+ throw UserException.validationError()
+ .message("A materialized view with given name [%s] already
exists in schema [%s]",
+ viewName, schemaPath)
+ .build(logger);
+ }
+ break;
+ case OR_REPLACE:
+ if (isTable) {
+ throw UserException.validationError()
+ .message("A non-view table with given name [%s] already exists
in schema [%s]",
+ viewName, schemaPath)
+ .build(logger);
+ } else if (isView) {
+ throw UserException.validationError()
+ .message("A regular view with given name [%s] already exists
in schema [%s]. " +
+ "Cannot replace a regular view with a materialized view.",
viewName, schemaPath)
+ .build(logger);
+ }
+ // Allow replacing existing materialized view
+ break;
+ case IF_NOT_EXISTS:
+ if (isTable || isView || isMaterializedView) {
+ return false;
+ }
+ break;
+ }
+ return true;
+ }
+ }
+
+ /**
+ * Handler for DROP MATERIALIZED VIEW DDL command.
+ */
+ public static class DropMaterializedView extends MaterializedViewHandler {
+
+ public DropMaterializedView(SqlHandlerConfig config) {
+ super(config);
+ }
+
+ @Override
+ public PhysicalPlan getPlan(SqlNode sqlNode) throws IOException,
ForemanSetupException {
+ SqlDropMaterializedView dropMV = unwrap(sqlNode,
SqlDropMaterializedView.class);
+ final String viewName =
DrillStringUtils.removeLeadingSlash(dropMV.getName());
+ final AbstractSchema drillSchema =
SchemaUtilities.resolveToMutableDrillSchema(
+ context.getNewDefaultSchema(), dropMV.getSchemaPath());
+
+ final String schemaPath = drillSchema.getFullSchemaName();
+
+ final Table viewToDrop = SqlHandlerUtil.getTableFromSchema(drillSchema,
viewName);
Review Comment:
Fixed
> Add Support for Materialized Views
> ----------------------------------
>
> Key: DRILL-8543
> URL: https://issues.apache.org/jira/browse/DRILL-8543
> Project: Apache Drill
> Issue Type: New Feature
> Components: Metadata, Query Planning & Optimization
> Affects Versions: 1.22.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.23.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
