[
https://issues.apache.org/jira/browse/DRILL-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076442#comment-14076442
]
Parth Chandra commented on DRILL-1197:
--------------------------------------
Hi Xiao,
I applied the patch to the latest master along with the patched for
DRILL-1021 and DROLL-998 and got merge conflicts. Can you check?
Also, it looks like there are multiple fixes, you've made. The change to
split the timeout for the query and handshake seem fine, but the other
changes/fixes are not obvious. Can you split those into a separate JIRA along
with a description of the problem? For instance, I don't understand why you
need to replace 'cancel' with 'shutdown'. Shutdown will invalidate the socket
forcing the application to reconnect if a query times out.
> C++ Client. Differentiate socket/handshake/query timeout for deadline timer.
> -----------------------------------------------------------------------------
>
> Key: DRILL-1197
> URL: https://issues.apache.org/jira/browse/DRILL-1197
> Project: Apache Drill
> Issue Type: New Feature
> Components: Client - C++
> Reporter: Xiao Meng
> Assignee: Xiao Meng
> Fix For: 0.5.0
>
> Attachments: DRILL-1197.1.patch.txt
>
>
> [#DRILL-852] introduced deadline timer to C++ Client. It use a global setting
> of timeout for all reading operation. We should differentiate timeout for
> different operations and also populate the status to client library user.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
