[ 
https://issues.apache.org/jira/browse/DRILL-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179245#comment-14179245
 ] 

Jinfeng Ni commented on DRILL-1539:
-----------------------------------

As discussed, two comments:

1. In copyValueSafe()
        this.to.lastPopulatedValueIndex++;
   which assumes copyValueSafe() is called incrementally with increasing value 
of "to".

   Will it make sense to change to the following? 

   this.to.lastPopulatedValueIndex = to;

2. Please check if RepeatedListVector has similar issue (Looks like it has 
similar code). If yes, please open another JIRA to fix the issue in 
RepeatedListVector. 

> RepeatedMapVector maintains incorrect last non-empty element index.
> -------------------------------------------------------------------
>
>                 Key: DRILL-1539
>                 URL: https://issues.apache.org/jira/browse/DRILL-1539
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Hanifi Gunes
>            Assignee: Jinfeng Ni
>         Attachments: DRILL-1539.1.patch.txt
>
>
> RepeatedMapVector maintains the last non-empty element index. The invariant 
> for the variable is that it must start from -1 and it must be less than the 
> group count. Current implementation violates this invariant. Drill will raise 
> IndexOutOfBounds exception for certain cases led by this violation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to