[ 
https://issues.apache.org/jira/browse/EAGLE-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787164#comment-15787164
 ] 

ASF GitHub Bot commented on EAGLE-845:
--------------------------------------

Github user zombieJ commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/753#discussion_r94208526
  
    --- Diff: 
eagle-hadoop-metric/src/main/webapp/app/apps/hadoop_metric/partials/overview.html
 ---
    @@ -20,11 +20,37 @@
        <div class="box-header with-border">
                <span class="fa fa-television"></span>
                <h3 class="box-title">
    -                   Summary
    +                   Service Summary Information
                </h3>
        </div>
        <div class="box-body">
    -           TODO: Your summary
    +
    +           <table class="table table-striped">
    +                   <tbody>
    +                   <tr ng-if="regiontotal > 0">
    +                           <th>RegionServer Status</th>
    +                           <td class="text-break">
    +                                   <a ui-sref="regionList({siteId: site})" 
target="_blank">{{regiontotal}} RegionServers</a>
    +                                   <span class="label 
label-success">{{regionhealtynum}} Healthy</span>
    +                                   <span class="label 
label-danger">{{regiontotal - regionhealtynum}} UnHealthy</span>
    +                           </td>
    +                   </tr>
    +                   <tr ng-if="hmasteractive !== undefined">
    --- End diff --
    
    Use `!!hmasteractive` or just `hmasteractive` instead.


> JMX Dashboard
> -------------
>
>                 Key: EAGLE-845
>                 URL: https://issues.apache.org/jira/browse/EAGLE-845
>             Project: Eagle
>          Issue Type: New Feature
>          Components: Hadoop JMX Monitor, Web UI
>            Reporter: JiJun Tang
>            Assignee: Lingang Deng
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to