[ 
https://issues.apache.org/jira/browse/EAGLE-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787159#comment-15787159
 ] 

ASF GitHub Bot commented on EAGLE-845:
--------------------------------------

Github user zombieJ commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/753#discussion_r94208119
  
    --- Diff: 
eagle-hadoop-metric/src/main/webapp/app/apps/hadoop_metric/ctrls/regionDetailCtrl.js
 ---
    @@ -0,0 +1,179 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +(function () {
    +   /**
    +    * `register` without params will load the module which using require
    +    */
    +   register(function (hadoopMetricApp) {
    +           hadoopMetricApp.controller("regionDetailCtrl", function ($q, 
$wrapState, $scope, PageConfig, Time, METRIC) {
    +                   var cache = {};
    +                   $scope.site = $wrapState.param.siteId;
    +                   $scope.hostname = $wrapState.param.hostname;
    +                   PageConfig.title = 'RegionServer ' + "(" + 
$scope.hostname + ")";
    +                   $scope.metricList = [];
    +                   Time.autoRefresh = false;
    +
    +                   var METRIC_NAME = [
    --- End diff --
    
    Same. Use api instead


> JMX Dashboard
> -------------
>
>                 Key: EAGLE-845
>                 URL: https://issues.apache.org/jira/browse/EAGLE-845
>             Project: Eagle
>          Issue Type: New Feature
>          Components: Hadoop JMX Monitor, Web UI
>            Reporter: JiJun Tang
>            Assignee: Lingang Deng
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to