[ 
https://issues.apache.org/jira/browse/EAGLE-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859206#comment-15859206
 ] 

ASF GitHub Bot commented on EAGLE-866:
--------------------------------------

Github user r7raul1984 commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/797#discussion_r100252845
  
    --- Diff: 
eagle-hadoop-metric/src/main/webapp/app/apps/hadoop_metric/index.js ---
    @@ -23,35 +23,35 @@
        var hadoopMetricApp = register(['ngRoute', 'ngAnimate', 'ui.router', 
'eagle.service']);
     
        hadoopMetricApp.route("HadoopMetric", {
    -           url: "/hadoopMetric?startTime&endTime",
    +           url: "/Service/HBase/overview?startTime&endTime",
    --- End diff --
    
    I think "/Service/HBase/overview" should be "/Services/HBase/overview"


> Refactor HBase JMX Metric with appropriate navigation path
> ----------------------------------------------------------
>
>                 Key: EAGLE-866
>                 URL: https://issues.apache.org/jira/browse/EAGLE-866
>             Project: Eagle
>          Issue Type: Sub-task
>          Components: Hadoop JMX Monitor
>    Affects Versions: v0.5.0
>            Reporter: Hao Chen
>            Assignee: Chang chen
>             Fix For: v0.5.0
>
>
> Please use same page redirection instead of always opening a new tab, with 
> appropriate navigation guide on top-right.
> * The navigation tree maybe like:
> {code}
> - $SITE_ID/Service/HBase -> show hbase overview metrics
> - $SITE_ID/Service/HBase/RegionServer -> show hbase regionserver list
> - $SITE_ID/Service/HBase/RegionServer/$REGION_SERVER_HOST -> show hbase 
> regionserver detail
> {code}
> * As to UI style, please refer to 
> https://almsaeedstudio.com/themes/AdminLTE/index2.html top-right-nav. 
> " [icon] Home > Dashboard"
> * As to URL path:
> {code}
> * ${APP_ID}/service/overview
> * ${APP_ID}/service/hbase 
> * ${APP_ID}/service/hbase/${HMASTER_HOSTNAME}
> * ${APP_ID}/service/hbase/regionserver
> * ${APP_ID}/service/hbase/regionserver/${HREGIONSERVER_HOSTNAME}
> // More services
> * ${APP_ID}/service/yarn
> * ${APP_ID}/service/hdfs
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to