[
https://issues.apache.org/jira/browse/EAGLE-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863352#comment-15863352
]
ASF GitHub Bot commented on EAGLE-868:
--------------------------------------
Github user zombieJ commented on a diff in the pull request:
https://github.com/apache/eagle/pull/792#discussion_r100747625
--- Diff:
eagle-hadoop-metric/src/main/webapp/app/apps/hadoop_metric/ctrls/overview.js ---
@@ -112,39 +113,56 @@
// TODO: Optimize the chart count
// TODO: ECharts dynamic refresh series bug:
https://github.com/ecomfe/echarts/issues/4033
-
-
+ $scope.chatnameList = ["MemoryUsage", "Master
Averageload", "Ritcount", "AssignOpsNum", "Assign", "BulkAssignOpsNum",
--- End diff --
merge `chatnameList`, `chatmetricList`, `chatdataoptionList`,
`chatlineNameList` into one array structure like:
```javascript
chartList = [
{
name: ...,
metrics: [...],
option: {...},
......
},
];
```
> Refactor metric chart render process to improve user experience.
> ----------------------------------------------------------------
>
> Key: EAGLE-868
> URL: https://issues.apache.org/jira/browse/EAGLE-868
> Project: Eagle
> Issue Type: Sub-task
> Components: App::Hadoop JMX Monitor, Core::UI Engine
> Reporter: Hao Chen
> Assignee: JiJun Tang
> Priority: Minor
> Fix For: v0.5.0
>
>
> *Problem*
> Currently when initially loading hbase metric page, there will be relatively
> long time that the whole metric dashboard is blank, then all charts and data
> are rendered at same time.
> *Improvements*
> * Refactor the metric load logic to : Load metric chart config -> show metric
> chart placeholder (show blank chart with no data) and show "data loading
> icon" for each chart one by one -> load metric data query for each chart ->
> reader metric data into metric chart when response returned and remove "data
> loading icon" one by one.
> * Add "loading-in-progress icon" with appropriate description during any
> long-time actions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
