Github user r7raul1984 commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/831#discussion_r102352634
  
    --- Diff: 
eagle-server/src/main/java/org/apache/eagle/server/authentication/config/UserAccount.java
 ---
    @@ -0,0 +1,61 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.eagle.server.authentication.config;
    +
    +import org.apache.eagle.common.authentication.UserPrincipal;
    +
    +import java.util.List;
    +
    +public class UserAccount {
    +    private String username;
    +    private String password;
    +    private List<UserPrincipal.Role> roles;
    +
    +    public UserAccount(String username, String password) {
    +        this.username = username;
    +        this.password = password;
    +    }
    +
    +    public String getUsername() {
    +        return username;
    +    }
    +
    +    public void setUsername(String username) {
    +        this.username = username;
    +    }
    +
    +    public String getPassword() {
    +        return password;
    +    }
    +
    +    public void setPassword(String password) {
    +        this.password = password;
    --- End diff --
    
     In order to make it more safe,I think that we should encrypt  the 
password .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to