[
https://issues.apache.org/jira/browse/EAGLE-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887137#comment-15887137
]
ASF GitHub Bot commented on EAGLE-924:
--------------------------------------
Github user chitin commented on a diff in the pull request:
https://github.com/apache/eagle/pull/840#discussion_r103366997
--- Diff:
eagle-metric/eagle-hbase-web/src/main/webapp/app/apps/hbase/ctrls/overview.js
---
@@ -59,7 +59,10 @@
$scope.site = $wrapState.param.siteId;
var result = cache[name] ||
activeMasterInfo._promise.then(function (res) {
- var hostname = cache[hostname]
= cache[hostname] || res[0].tags.hostname;
+ if(typeof res[0].tags ===
'undefined') {
--- End diff --
Thanks for your review and suggestion, I have fix it.
> urls to healthy and unhealthy region-servers in hbase dashboard is not
> accurate enough
> --------------------------------------------------------------------------------------
>
> Key: EAGLE-924
> URL: https://issues.apache.org/jira/browse/EAGLE-924
> Project: Eagle
> Issue Type: Bug
> Components: App::Hadoop JMX Monitor
> Affects Versions: v0.5.0
> Reporter: Michael Wu
> Assignee: Lingang Deng
> Fix For: v0.5.0
>
> Attachments: Screen Shot 2017-02-22 at 16.24.09.png
>
>
> Issue: In hbase dashboard of a site, in the top section, there are 2 links
> referring to urls of healthy and unhealthy region-server lists. But
> currently, when people click the link, the page is directed to a full list of
> all region-servers, not the corresponding healthy-list or unhealthy-list.
> Suggestion: we can add some filter in the url, for example, append
> "?status=healthy" or "?status=unhealthy" to the url, and update the link with
> new urls.
> Please see the screenshot in the attachment of this ticket.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
