GitHub user asdf2014 opened a pull request:
https://github.com/apache/eagle/pull/920
[EAGLE-1009] Fix losing exception issues
`return` inside `finally` block will result in losing exception:
* If the finally block completes abruptly for reason S, then the try
statement completes abruptly for reason S (and the throw of value V is
discarded and forgotten).
* If the finally block completes abruptly for reason S, then the try
statement completes abruptly for reason S (and reason R is discarded).
reference:
http://docs.oracle.com/javase/specs/jls/se8/html/jls-14.html#jls-14.20.2
(https://issues.apache.org/jira/browse/EAGLE-1009)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asdf2014/eagle return_inside_finally
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #920
----
commit d7c2e08b0bac07e3da397fc7843e5bd49db5f896
Author: asdf2014 <1571805...@qq.com>
Date: 2017-04-18T09:16:54Z
Fix losing exception issues
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
