Github user qingwen220 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/926#discussion_r113703970
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertPublisherImpl.java
---
@@ -73,11 +76,11 @@ public void nextEvent(PublishPartition partition,
AlertStreamEvent event) {
private void notifyAlert(PublishPartition partition, AlertStreamEvent
event) {
// remove the column values for publish plugin match
partition.getColumnValues().clear();
- if (!publishPluginMapping.containsKey(partition)) {
+ if (!publishPluginMapping.containsKey(partition.getPublishId())) {
--- End diff --
Sorry for the late reply.
For the alert dropping off of unwanted stream is handled in
AlertBoltOutputCollectorWrapper, which are kept as it is.
In this class, i just simplify the coding, which should keeps the original
logic. How do you think? @garrettlish
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
