Alonexc opened a new issue, #3473:
URL: https://github.com/apache/incubator-eventmesh/issues/3473

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   
![image](https://user-images.githubusercontent.com/91315508/225790586-164af8c7-d10d-41d1-b4b5-dd766758ec2a.png)
   
![image](https://user-images.githubusercontent.com/91315508/225790590-81665178-e690-4d71-b62f-9ba032de2516.png)
   located at:
   
eventmesh-protocol-plugin/eventmesh-protocol-cloudevents/src/main/java/org/apache/eventmesh/protocol/cloudevents/resolver/http/SendMessageBatchV2ProtocolResolver.java
 line 65,84
   analysis and explanation:
   Having two cases in a switch statement or two branches in an if chain with 
the same implementation is at best duplicate code, and at worst a coding error. 
If the same logic is truly needed for both instances, then in an if chain they 
should be combined, or for a switch, one should fall through to the other.
   
   
   ### Describe the solution you'd like
   
   
![image](https://user-images.githubusercontent.com/91315508/225790625-c782fff4-b042-44c9-b7b4-805b0f588234.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to