Alonexc opened a new issue, #3503:
URL: https://github.com/apache/incubator-eventmesh/issues/3503

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   
![image](https://user-images.githubusercontent.com/91315508/226833522-8061f0e9-df41-46b8-a873-f0c100163ce4.png)
   located at:
   
eventmesh-storage/eventmesh-storage-pravega/src/main/java/org/apache/eventmesh/storage/pravega/client/PravegaClient.java
 line 191
   analysis and explanation:
   The underlying implementation of String::replaceAll calls the 
java.util.regex.Pattern.compile() method each time it is called even if the 
first argument is not a regular expression. This has a significant performance 
cost and therefore should be used with care.
   When String::replaceAll is used, the first argument should be a real regular 
expression. If it’s not the case, String::replace does exactly the same thing 
as String::replaceAll without the performance drawback of the regex.
   
   
   ### Describe the solution you'd like
   
   Use "replace()" instead of "replaceAll()".
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to