Alonexc opened a new issue, #3511:
URL: https://github.com/apache/incubator-eventmesh/issues/3511

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   
![image](https://user-images.githubusercontent.com/91315508/226835498-58ae8cfb-6064-404f-bca9-510be23c62d3.png)
   located at:
   
eventmesh-storage/eventmesh-storage-rabbitmq/src/test/java/org/apache/eventmesh/storage/rabbitmq/config/ConfigurationHolderTest.java
 line 50-60
   analysis and explanation:
   The standard assertions library methods such as 
org.junit.Assert.assertEquals, and org.junit.Assert.assertSame expect the first 
argument to be the expected value and the second argument to be the actual 
value. For AssertJ, it’s the other way around, the argument of 
org.assertj.core.api.Assertions.assertThat is the actual value, and the 
subsequent calls contain the expected values. Swap them, and your test will 
still have the same outcome (succeed/fail when it should) but the error 
messages will be confusing.
   
   
   ### Describe the solution you'd like
   
   Swap actual and expected values.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to