[GitHub] [incubator-eventmesh] hgaol commented on pull request #3524: [ISSUE #3523] fix json serialization issue when using redis

[via GitHub]

hgaol commented on PR #3524:
URL: 
https://github.com/apache/incubator-eventmesh/pull/3524#issuecomment-1484556058

   > > > <img alt="image" width="429" 
src="https://user-images.githubusercontent.com/29346818/227404279-405baf37-1a17-45b0-b4cc-8fdfaff965a6.png";>
   > > > Please pass through the header, do not write hard.
   > > 
   > > 
   > > Hi @mytang0 . Do you mean the Package header? I saw all of current 
headers are consistent for `EventMeshMessage`, see screenshot below. Or should 
I add another headers property with type `HashMap` in `EventMeshMessage`, and 
add all the headers in `Package.Header`? pls let me know your preference. 
Thanks! <img alt="image" width="812" 
src="https://user-images.githubusercontent.com/11908658/227476330-80387122-802d-4f33-a5fa-1cf4ef547209.png";>
   > 
   > Hello, that's what i thought
   > 
   > * By default, dataContentType is 'application/json'. The problem with the 
test case is that the body is not json. So fixing 'text/plain' directly is 
problematic.
   > * Therefore, to fundamentally solve this problem. The specified 
dataContentType that non-json needs to display when the producer publishes a 
message, and then pass the dataContentType on.
   > * You are right to think about it. We can be simple first, directly in the 
header.properties
   
   updated. pls let me know if any comment. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: issues-h...@eventmesh.apache.org