hgaol commented on PR #3524: URL: https://github.com/apache/eventmesh/pull/3524#issuecomment-1486850560
> > don't know why CI still error, I didn't change this class and it's succeeded to build on my local machine... <img alt="image" width="1122" src="https://user-images.githubusercontent.com/11908658/228134038-aed3376a-3401-417b-bf3e-48682787755d.png"> > > you can find this under the `HTTPClientHandler` , because using try-catch with resource, you can remove the `out.write` in the catch block with the `log.error` instead. seems the github action will link this PR branch to another one, maybe the master branch. In my branch for the PR, the `HTTPClientHandler` is different. You can find the code below. I didn't use the `checkout` github action for long time, and will find some time to learn if it's by design... https://github.com/hgaol/incubator-eventmesh/blob/3523/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/HTTPClientHandler.java#L98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
