devCod3r commented on code in PR #3659:
URL: https://github.com/apache/eventmesh/pull/3659#discussion_r1161474700
##########
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/admin/handler/RedirectClientByPathHandlerTest.java:
##########
@@ -124,7 +124,7 @@ public void testHandle() throws IOException {
clientMockedStatic.when(() ->
EventMeshTcp2Client.redirectClient2NewEventMesh(any(), anyString(), anyInt(),
any(),
any())).thenThrow(new RuntimeException());
redirectClientByPathHandler.handle(mockExchange);
- String response = outputStream.toString();
+ String response =
outputStream.toString(StandardCharsets.UTF_8.name());
Review Comment:
Hi @mxsm / @Alonexc / @xwm1992 - Should I go ahead with the above mentioned
changes as well?
I.e. replacing StandardCharsets.UTF_8 with Constants.DEFAULT_CHARSET on line
107 and 117 along with the changes made for this issue on line 128
[RedirectClientByPathHandlerTest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
