Alonexc commented on code in PR #3691:
URL: https://github.com/apache/eventmesh/pull/3691#discussion_r1162226785
##########
eventmesh-examples/src/main/java/org/apache/eventmesh/tcp/common/EventMeshTestUtils.java:
##########
@@ -38,6 +38,9 @@
import java.util.UUID;
import java.util.concurrent.ThreadLocalRandom;
+import javax.lang.model.element.PackageElement;
Review Comment:
Just extracting the duplicate code as a method, why would you use these two
imports?
##########
eventmesh-examples/src/main/java/org/apache/eventmesh/tcp/common/EventMeshTestUtils.java:
##########
@@ -49,120 +52,101 @@ public class EventMeshTestUtils {
private static final String DEFAULT_TTL_MS = "30000";
+
+ private static UserAgent getUserAgent(Integer port, String subsystem1,
Integer pid){
Review Comment:
subsystem1->subsystem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
