Alonexc commented on code in PR #3715:
URL: https://github.com/apache/eventmesh/pull/3715#discussion_r1165112783
##########
eventmesh-registry-plugin/eventmesh-registry-etcd/src/main/java/org/apache/eventmesh/registry/etcd/service/EtcdRegistryService.java:
##########
@@ -204,7 +206,7 @@ public boolean register(EventMeshRegisterInfo
eventMeshRegisterInfo) throws Regi
EventMeshDataInfo eventMeshDataInfo =
new EventMeshDataInfo(eventMeshClusterName, eventMeshName,
endPoint, System.currentTimeMillis(),
eventMeshRegisterInfo.getMetadata());
- ByteSequence etcdValue =
ByteSequence.from(JsonUtils.toJSONString(eventMeshDataInfo).getBytes(Constants.DEFAULT_CHARSET));
+ ByteSequence etcdValue =
ByteSequence.from(Objects.requireNonNull(JsonUtils.toJSONString(eventMeshDataInfo)).getBytes(Constants.DEFAULT_CHARSET));
Review Comment:
This line is too long and will cause the checkstyle check to fail, so
suggest a line break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
