pandaapo commented on issue #3470: URL: https://github.com/apache/eventmesh/issues/3470#issuecomment-1518007900
https://github.com/apache/eventmesh/blob/7d3bbde05289982d19ab39ff1a8f1c55a382e5d5/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java#L71-L87 I‘m not sure this is a issue. Although `EventMeshMessageTCPSubClient#reconnect()` has no `synchronized`, it has `synchronized` in the method body. `super.reconnect()` has `synchronized`, too. The logic of `hello()` involves only one global variable `contexts` and it is CHM. The logic of `listen()` is similar to `hello()`. It seems that there is no need to add `synchronized`. Is there any problem with my analysis? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
