xwm1992 commented on code in PR #3819:
URL: https://github.com/apache/eventmesh/pull/3819#discussion_r1185902661
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/producer/SendMessageContext.java:
##########
@@ -123,13 +123,13 @@ public String toString() {
}
@Override
- public boolean retry() throws Exception {
+ public void retry() throws Exception {
if (eventMeshProducer == null) {
- return false;
+ log.error("Exception happends during retry. EventMeshProduceer is
null.");
}
if (retryTimes > 0) { //retry once
- return false;
+ log.error("Exception happends during retry. The retryTimes > 0.");
Review Comment:
same as above
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/producer/SendMessageContext.java:
##########
@@ -123,13 +123,13 @@ public String toString() {
}
@Override
- public boolean retry() throws Exception {
+ public void retry() throws Exception {
if (eventMeshProducer == null) {
- return false;
+ log.error("Exception happends during retry. EventMeshProduceer is
null.");
Review Comment:
here need add return in if block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
