pandaapo commented on code in PR #3819:
URL: https://github.com/apache/eventmesh/pull/3819#discussion_r1186184235
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/producer/SendMessageContext.java:
##########
@@ -123,13 +123,13 @@ public String toString() {
}
@Override
- public boolean retry() throws Exception {
+ public void retry() throws Exception {
if (eventMeshProducer == null) {
- return false;
+ log.error("Exception happends during retry. EventMeshProduceer is
null.");
Review Comment:
I was merging 3 `RetryContext`s in module http, grpc and tcp to one.
3 `RetryContext`s have almost same structure except a little difference.
This `retry()` is that difference. It returns boolean in module http, grpc, and
void in module tcp. Then I checked all calls of `retry()` that returns boolean.
I found the return value of boolean has no practical use in all calls. So I
chose to modify it to `void` to keep with `retry()` in module tcp.
If the return value of boolean type is indeed useful, may I modify the void
to boolean in module tcp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
