pandaapo opened a new issue, #3897:
URL: https://github.com/apache/eventmesh/issues/3897

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   org.apache.eventmesh.api.admin.Admin
   org.apache.eventmesh.storage.rocketmq.admin.RocketMQAdmin, AbstractRmqAdmin
   org.apache.eventmesh.storage.standalone.admin.StandaloneAdmin
   1. `AbstractRmqAdmin`'s field `adminExt`, is instantiated in the beginning, 
set to null at the end in every methods. So it lose the meaning as member field.
   
   2.  `AbstractRmqAdmin`'s code can be write in its only subclass ``, then we 
can get more simple code structure.
   
   3. There are same field and methods in `RocketMQAdmin` and `StandaloneAdmin` 
as subclass of `Admin`.
   
   ### Describe the solution you'd like
   
   1. Make `adminExt` be local variable.
   2. Merge `AbstractRmqAdmin`'s code into `RocketMQAdmin`.
   3. Extract the shared field and method of `RocketMQAdmin` and 
`StandaloneAdmin`.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to