pandaapo commented on code in PR #3867:
URL: https://github.com/apache/eventmesh/pull/3867#discussion_r1193975690
##########
eventmesh-storage-plugin/eventmesh-storage-kafka/src/main/java/org/apache/eventmesh/storage/kafka/producer/ProducerImpl.java:
##########
@@ -42,36 +41,20 @@
@Slf4j
@SuppressWarnings("deprecation")
-public class ProducerImpl {
+public class ProducerImpl extends AbstractProducer {
private final KafkaProducer<String, CloudEvent> producer;
- private final Properties properties = new Properties();
- private final AtomicBoolean isStarted = new AtomicBoolean(false);
public ProducerImpl(Properties props) {
+ super(props);
+ properties.clear();
Review Comment:
Because `super(props)` assigns param `props` to field `properties`. but
`ProducerImpl` does not assign value like that. What it do to `properties` is
just the next 3 line.
https://github.com/apache/eventmesh/blob/470329d7e3c69fa241762b364f1cd1799a3b5766/eventmesh-storage-plugin/eventmesh-storage-kafka/src/main/java/org/apache/eventmesh/storage/kafka/producer/ProducerImpl.java#L51-L54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
