Pil0tXia commented on PR #4139: URL: https://github.com/apache/eventmesh/pull/4139#issuecomment-1601294476
> It's OK for me after you remove the old comment `// Verify that the compiledUrlMappingPattern field is updated`. Of course, I have committed the changes. I have a slight confusion in that although the `assertNotNull()` method does not verify that the `compiledUrlMappingPattern` matches the `mockedPattern` as the `assertEquals()` method did before, it still ensures that the `compiledUrlMappingPattern` has been updated by not being null. Could you kindly enlighten me on the reasons behind your thoughts, if you don't mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
