dipankr commented on code in PR #4155:
URL: https://github.com/apache/eventmesh/pull/4155#discussion_r1241478496
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/SessionSender.java:
##########
@@ -139,6 +139,7 @@ public EventMeshTcpSendResult send(Header header,
CloudEvent event, SendCallback
Objects.requireNonNull(session.getClientGroupWrapper().get())
.send(upStreamMsgContext, sendCallback);
} finally {
+
session.getSender().getFailMsgCount().incrementAndGet();
Review Comment:
> why you add failMsgCount at here?
In #4103, in fixes section, it was mentioned to add this line at line 142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
