Pil0tXia commented on code in PR #3594:
URL: https://github.com/apache/eventmesh/pull/3594#discussion_r1257269857
##########
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/boot/EventMeshServerTest.java:
##########
@@ -60,56 +60,56 @@ private void testGetConfigWhenStartup(Boolean hasEnv)
throws Exception {
}
private void assertTCPConfig(EventMeshTCPConfiguration config) {
- Assert.assertEquals(config.getEventMeshTcpServerPort(), 816);
- Assert.assertEquals(config.getEventMeshTcpIdleAllSeconds(), 1816);
- Assert.assertEquals(config.getEventMeshTcpIdleWriteSeconds(), 2816);
- Assert.assertEquals(config.getEventMeshTcpIdleReadSeconds(), 3816);
- Assert.assertEquals(config.getEventMeshTcpMsgReqnumPerSecond(),
Integer.valueOf(4816));
- Assert.assertEquals(config.getEventMeshTcpClientMaxNum(), 5816);
- Assert.assertEquals(config.getEventMeshTcpGlobalScheduler(), 6816);
-
Assert.assertEquals(config.getEventMeshTcpTaskHandleExecutorPoolSize(), 7816);
-
Assert.assertEquals(config.getEventMeshTcpMsgDownStreamExecutorPoolSize(),
8816);
- Assert.assertEquals(config.getEventMeshTcpSessionExpiredInMills(),
1816);
- Assert.assertEquals(config.getEventMeshTcpSessionUpstreamBufferSize(),
11816);
- Assert.assertEquals(config.getEventMeshTcpMsgAsyncRetryTimes(), 12816);
- Assert.assertEquals(config.getEventMeshTcpMsgSyncRetryTimes(), 13816);
- Assert.assertEquals(config.getEventMeshTcpMsgRetrySyncDelayInMills(),
14816);
- Assert.assertEquals(config.getEventMeshTcpMsgRetryAsyncDelayInMills(),
15816);
- Assert.assertEquals(config.getEventMeshTcpMsgRetryQueueSize(), 16816);
- Assert.assertEquals(config.getEventMeshTcpRebalanceIntervalInMills(),
Integer.valueOf(17816));
- Assert.assertEquals(config.getEventMeshServerAdminPort(), 18816);
- Assert.assertEquals(config.isEventMeshTcpSendBackEnabled(),
Boolean.TRUE);
- Assert.assertEquals(config.getEventMeshTcpSendBackMaxTimes(), 3);
-
Assert.assertEquals(config.getEventMeshTcpPushFailIsolateTimeInMills(), 21816);
- Assert.assertEquals(config.getGracefulShutdownSleepIntervalInMills(),
22816);
- Assert.assertEquals(config.getSleepIntervalInRebalanceRedirectMills(),
23816);
- Assert.assertEquals(config.getEventMeshEventSize(), 22816);
- Assert.assertEquals(config.getEventMeshEventBatchSize(), 23816);
+ Assert.assertEquals(816,config.getEventMeshTcpServerPort());
+ Assert.assertEquals(1816,config.getEventMeshTcpIdleAllSeconds());
+ Assert.assertEquals(2816,config.getEventMeshTcpIdleWriteSeconds());
+ Assert.assertEquals(3816,config.getEventMeshTcpIdleReadSeconds());
+
Assert.assertEquals(Integer.valueOf(4816),config.getEventMeshTcpMsgReqnumPerSecond());
+ Assert.assertEquals(5816,config.getEventMeshTcpClientMaxNum());
+ Assert.assertEquals(6816,config.getEventMeshTcpGlobalScheduler());
+
Assert.assertEquals(7816,config.getEventMeshTcpTaskHandleExecutorPoolSize());
+
Assert.assertEquals(8816,config.getEventMeshTcpMsgDownStreamExecutorPoolSize());
+
Assert.assertEquals(1816,config.getEventMeshTcpSessionExpiredInMills());
+
Assert.assertEquals(11816,config.getEventMeshTcpSessionUpstreamBufferSize());
+ Assert.assertEquals(12816,config.getEventMeshTcpMsgAsyncRetryTimes());
+ Assert.assertEquals(13816,config.getEventMeshTcpMsgSyncRetryTimes());
+
Assert.assertEquals(14816,config.getEventMeshTcpMsgRetrySyncDelayInMills());
+
Assert.assertEquals(15816,config.getEventMeshTcpMsgRetryAsyncDelayInMills());
+ Assert.assertEquals(16816,config.getEventMeshTcpMsgRetryQueueSize());
+
Assert.assertEquals(Integer.valueOf(17816),config.getEventMeshTcpRebalanceIntervalInMills());
+ Assert.assertEquals(18816,config.getEventMeshServerAdminPort());
+
Assert.assertEquals(Boolean.TRUE,config.isEventMeshTcpSendBackEnabled());
+ Assert.assertEquals(3,config.getEventMeshTcpSendBackMaxTimes());
+
Assert.assertEquals(21816,config.getEventMeshTcpPushFailIsolateTimeInMills());
+
Assert.assertEquals(22816,config.getGracefulShutdownSleepIntervalInMills());
+
Assert.assertEquals(23816,config.getSleepIntervalInRebalanceRedirectMills());
+ Assert.assertEquals(22816,config.getEventMeshEventSize());
+ Assert.assertEquals(23816,config.getEventMeshEventBatchSize());
}
private void assertCommonConfig(CommonConfiguration config) {
- Assert.assertEquals("env-succeed!!!", config.getEventMeshEnv());
- Assert.assertEquals("idc-succeed!!!", config.getEventMeshIDC());
- Assert.assertEquals("cluster-succeed!!!",
config.getEventMeshCluster());
- Assert.assertEquals("name-succeed!!!", config.getEventMeshName());
- Assert.assertEquals("816", config.getSysID());
- Assert.assertEquals("connector-succeed!!!",
config.getEventMeshConnectorPluginType());
- Assert.assertEquals("storage-succeed!!!",
config.getEventMeshStoragePluginType());
- Assert.assertEquals("security-succeed!!!",
config.getEventMeshSecurityPluginType());
- Assert.assertEquals("registry-succeed!!!",
config.getEventMeshRegistryPluginType());
- Assert.assertEquals("trace-succeed!!!",
config.getEventMeshTracePluginType());
- Assert.assertEquals("hostIp-succeed!!!",
config.getEventMeshServerIp());
+ Assert.assertEquals(config.getEventMeshEnv(),"env-succeed!!!");
+ Assert.assertEquals(config.getEventMeshIDC(),"idc-succeed!!!");
+ Assert.assertEquals(config.getEventMeshCluster(),"cluster-succeed!!!");
+ Assert.assertEquals(config.getEventMeshName(),"name-succeed!!!");
+ Assert.assertEquals(config.getSysID(),"816");
+
Assert.assertEquals(config.getEventMeshConnectorPluginType(),"connector-succeed!!!");
+
Assert.assertEquals(config.getEventMeshStoragePluginType(),"storage-succeed!!!");
+
Assert.assertEquals(config.getEventMeshSecurityPluginType(),"security-succeed!!!");
+
Assert.assertEquals(config.getEventMeshRegistryPluginType(),"registry-succeed!!!");
+
Assert.assertEquals(config.getEventMeshTracePluginType(),"trace-succeed!!!");
+ Assert.assertEquals(config.getEventMeshServerIp(),"hostIp-succeed!!!");
List<String> list = new ArrayList<>();
list.add("metrics-succeed1!!!");
list.add("metrics-succeed2!!!");
list.add("metrics-succeed3!!!");
- Assert.assertEquals(list, config.getEventMeshMetricsPluginType());
+ Assert.assertEquals(config.getEventMeshMetricsPluginType(),list);
Assert.assertTrue(config.isEventMeshServerSecurityEnable());
Assert.assertTrue(config.isEventMeshServerRegistryEnable());
Assert.assertTrue(config.isEventMeshServerTraceEnable());
- Assert.assertEquals("eventmesh.idc-succeed!!!",
config.getEventMeshWebhookOrigin());
+
Assert.assertEquals(config.getEventMeshWebhookOrigin(),"eventmesh.idc-succeed!!!");
Review Comment:
Please restore the changes in these lines, the original order of 'expect'
and 'actual' is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
