Pil0tXia commented on code in PR #4253:
URL: https://github.com/apache/eventmesh/pull/4253#discussion_r1268845144
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/AssertUtils.java:
##########
@@ -27,35 +27,35 @@
public final class AssertUtils {
/**
- * assert obj not null
+ * Assert actual is not null
*
- * @param obj obj
+ * @param actual Object to test
* @param message error message
*/
- public static void notNull(final Object obj, final String message) {
- isTrue(Objects.nonNull(obj), message);
+ public static void notNull(final Object actual, final String message) {
+ isTrue(Objects.nonNull(actual), message);
}
/**
- * assert test is true
+ * Assert actual is true
*
- * @param test test
+ * @param actual boolean to test
* @param message error message
*/
- public static void isTrue(final Boolean test, final String message) {
- if (!Boolean.TRUE.equals(test)) {
+ public static void isTrue(final Boolean actual, final String message) {
+ if (!Boolean.TRUE.equals(actual)) {
throw new IllegalArgumentException(message);
Review Comment:
If there is no logic in the code that needs to compare the expected value to
the actual value, and there is no expected value that needs to be compared,
then there is no need to name a single parameter `actual`.
Besides, "actual" is an adjective.
The same applies to the other two methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
