Alonexc opened a new issue, #4266:
URL: https://github.com/apache/eventmesh/issues/4266

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   located at:
   
eventmesh-connectors/eventmesh-connector-openfunction/src/main/java/org/apache/eventmesh/connector/openfunction/sink/connector/OpenFunctionSinkConnector.java
 line 77
   
eventmesh-connectors/eventmesh-connector-openfunction/src/main/java/org/apache/eventmesh/connector/openfunction/source/connector/OpenFunctionSourceConnector.java
 line 90
   
eventmesh-connectors/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/sink/connector/RocketMQSinkConnector.java
 80
   analysis and explanation:
   InterruptedExceptions should never be ignored in the code, and simply 
logging the exception counts in this case as "ignoring". The throwing of the 
InterruptedException clears the interrupted state of the Thread, so if the 
exception is not handled properly the information that the thread was 
interrupted will be lost. Instead, InterruptedExceptions should either be 
rethrown - immediately or after cleaning up the method’s state - or the thread 
should be re-interrupted by calling Thread.interrupt() even if this is supposed 
to be a single-threaded application. Any other course of action risks delaying 
thread shutdown and loses the information that the thread was interrupted - 
probably without finishing its task.
   
   
   ### Describe the solution you'd like
   
   Restore interrupted state
   
![image](https://github.com/apache/eventmesh/assets/91315508/eaef9af8-be94-426a-964e-8c33a05ec54a)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to