Pil0tXia commented on code in PR #4270:
URL: https://github.com/apache/eventmesh/pull/4270#discussion_r1270950834
##########
eventmesh-protocol-plugin/eventmesh-protocol-meshmessage/src/main/java/org/apache/eventmesh/protocol/meshmessage/MeshMessageProtocolAdaptor.java:
##########
@@ -108,31 +107,33 @@ public List<CloudEvent>
toBatchCloudEvent(ProtocolTransportObject protocol) thro
public ProtocolTransportObject fromCloudEvent(CloudEvent cloudEvent)
throws ProtocolHandleException {
validateCloudEvent(cloudEvent);
String protocolDesc =
- cloudEvent.getExtension(Constants.PROTOCOL_DESC) == null ? null :
cloudEvent.getExtension(Constants.PROTOCOL_DESC).toString();
-
- if (StringUtils.equals(MeshMessageProtocolConstant.PROTOCOL_DESC_HTTP,
protocolDesc)) {
- HttpCommand httpCommand = new HttpCommand();
- Body body = new Body() {
- final Map<String, Object> map = new HashMap<>();
-
- @Override
- public Map<String, Object> toMap() {
- if (cloudEvent.getData() == null) {
+ cloudEvent.getExtension(Constants.PROTOCOL_DESC) == null ?
null : cloudEvent.getExtension(Constants.PROTOCOL_DESC).toString();
+
+ switch (Objects.requireNonNull(protocolDesc)) {
+ case MeshMessageProtocolConstant.PROTOCOL_DESC_HTTP:
+ HttpCommand httpCommand = new HttpCommand();
+ Body body = new Body() {
+ final Map<String, Object> map = new HashMap<>();
+
+ @Override
+ public Map<String, Object> toMap() {
+ if (cloudEvent.getData() == null) {
+ return map;
+ }
+
map.put(MeshMessageProtocolConstant.PROTOCOL_KEY_CONTENT, new
String(cloudEvent.getData().toBytes(),
+ Constants.DEFAULT_CHARSET));
Review Comment:
Like this:
```java
map.put(MeshMessageProtocolConstant.PROTOCOL_KEY_CONTENT,
new String(cloudEvent.getData().toBytes(),
Constants.DEFAULT_CHARSET));
```
Because `new String(cloudEvent.getData().toBytes(),
Constants.DEFAULT_CHARSET)` is the second param of `map.put`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
