Pil0tXia commented on PR #4273: URL: https://github.com/apache/eventmesh/pull/4273#issuecomment-1647983506
@pandaapo Thank you for your attention. 1. The roles of `cloudEventSource` and `manufacturerDomain` are the same. 2. The properties defined within `WebHookConfig` should be related to Webhook configurations. **The variable names defined in this file will be exposed to users as JSON parameters.** The variable naming for `manufacturerDomain` and `manufacturerName` is chosen to intuitively indicate the type of values these fields should accept. However, cloudEventSource is an internal concept of the EventMesh and should not be exposed to users or require them to **speculate about its meaning**, especially in the absence of documentation. 3. In fact, `cloudEventSource` currently serves no purpose and has been deprecated for a long time. The method that should actually call it uses hardcoding (which has been fixed in this PR), and even the test classes incorrectly assign values to it. This indicates that, apart from its definer, no one knows how to use it. This is also one of the reasons for my proposed name modification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
