pandaapo commented on PR #4359: URL: https://github.com/apache/eventmesh/pull/4359#issuecomment-1677071018
1: > Fix three optimizations mentioned in issue https://github.com/apache/eventmesh/issues/4190. Could you explain why you do not fix the 4th problem "d. Excessive lambda usage[line 247,249]" in this issue? If no specific reason, I suggest you reopen this automatically closed issue and add a comment to indicate that the issue is still uncompleted for the community to continue working on it. 2: Regarding the `transient` modifier, the proposed solution mentioned in the issue is `implements Serializable`, which means keeping all `transient` modifiers. You resolved it in a different way (removing 6 `transient` modifiers and keeping 2) without any additional explanation. Could you supply a note here about the reason behind your modification? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
