pandaapo commented on code in PR #4361:
URL: https://github.com/apache/eventmesh/pull/4361#discussion_r1294177277
##########
eventmesh-examples/src/main/java/org/apache/eventmesh/http/demo/sub/service/SubService.java:
##########
@@ -56,21 +57,28 @@ public class SubService implements InitializingBean {
private transient Properties properties;
+ {
+ try {
+ properties =
Utils.readPropertiesFile(ExampleConstants.CONFIG_FILE_NAME);
+ } catch (IOException e) {
+ log.error("read properties file failed", e);
+ }
+ }
+
+ final String localPort = properties.getProperty(SERVER_PORT);
+ final String testURL = getURL(localPort, "/sub/test");
+
private final transient List<SubscriptionItem> topicList =
Lists.newArrayList(
new SubscriptionItem(ExampleConstants.EVENTMESH_HTTP_ASYNC_TEST_TOPIC,
SubscriptionMode.CLUSTERING, SubscriptionType.ASYNC)
);
- private transient String testURL;
Review Comment:
Could we remove the `transient` of all remaining fields in this class? After
all, they have no meaning in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
