pandaapo commented on PR #4365: URL: https://github.com/apache/eventmesh/pull/4365#issuecomment-1679792689
First of all, I like your way of submitting PR: breaking down a task into multiple PRs, which avoids submitting a very large PR all at once. Your approach can greatly improve the quality of review and reduce the difficulty of review. :thumbsup: Secondly, since your initial implementation has not been applied to the business of EventMesh yet, could you please add documentation to your code (including classes and methods) to help developers and reviewers understand their purpose and future roles in EventMesh? Also, please refer to https://eventmesh.apache.org/community/contribute/contribute/#code-style to check your code style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
