Pil0tXia commented on code in PR #126:
URL: https://github.com/apache/eventmesh-site/pull/126#discussion_r1318042584


##########
i18n/zh/docusaurus-plugin-content-docs/current/instruction/01-store.md:
##########
@@ -1,51 +1,47 @@
 # 部署 EventMesh 的事件存储
 
-## 依赖
+eventmesh在非standalone模式下,依赖RocketMQ作为存储层;若采用standalone模式,则可跳过该步,直接进行runtime的部署。
+
+## 1. 依赖
 
 ```
 建议使用64位操作系统,建议使用Linux/Unix;
-64位JDK 1.8+;
-Gradle至少为7.0, 推荐7.0.*
-4g+可用磁盘用于eventmesh-store服务器
-eventmesh在非standalone模式下,依赖RocketMQ作为存储层;若采用standalone模式,则可跳过该步,直接进行runtime的部署
+64位JDK 1.8+;
+Gradle至少为7.0, 推荐7.0.*;
+4g+可用磁盘用于eventmesh-store服务器;
 ```
 
+## 2. 二进制部署
 
-## 下载
+### 2.1 下载
 
-从 [RocketMQ官方网站](https://rocketmq.apache.org/download/) 
下载Binary代码(推荐使用4.9.*版本),这里以4.9.4为例
+从[RocketMQ官方网站](https://rocketmq.apache.org/download/) 
下载Binary代码(推荐使用4.9.*版本),这里以4.9.4为例:
 
 ```
 unzip rocketmq-all-4.9.4-bin-release.zip
-cd rocketmq-4.9.4/
+cd rocketmq-all-4.9.4-bin-release/
 ```
 
+![rocketmq_1](/images/install/rocketmq_1.png)
 
-## 部署
+### 2.2 启动
 
-- #### 启动Name Server
+启动Name Server:
 
 ```
-nohup sh bin/mqnamesrv &
-tail -f ~/logs/rocketmqlogs/namesrv.log
+nohup sh bin/mqnamesrv & tail -f ~/logs/rocketmqlogs/namesrv.log
 ```
 
-如果在看到The Name Server boot success...,则说明Name Server启动成功
+如果在看到The Name Server boot success...,则说明Name Server启动成功。
+
+![rocketmq_2](/images/install/rocketmq_2.png)
 
-- #### 启动Broker
+启动Broker:
 
 ```
-nohup sh bin/mqbroker -n localhost:9876 &
-tail -f ~/logs/rocketmqlogs/broker.log
+nohup sh bin/mqbroker -n localhost:9876 & tail -f 
~/logs/rocketmqlogs/broker.log
 ```
 
-如果在看到The broker boot success...,则说明Broker启动成功
-
-至此eventmesh-store的部署已完成,请转至下一步完成 
[eventmesh-runtime](https://github.com/apache/incubator-eventmesh/blob/master/docs/zh/instruction/02-runtime.md)
 的部署
-

Review Comment:
   This instruction is needed both in eventmesh-store deployment with docker 
and without docker.



##########
blog/cncf-serverlessworkflow-official-recommends-eventmesh-as-runtime-impl.md:
##########
@@ -6,7 +6,7 @@ CNCF [Serverless Workflow](https://serverlessworkflow.io/) 
defines a vendor-neut
 
 This project is composed of:
 
-* [Specification](specification.md) for defining DSL-based workflows
+* 
[Specification](https://github.com/serverlessworkflow/specification/blob/main/specification.md#using-functions-for-async-api-service-invocations)
 for defining DSL-based workflows

Review Comment:
   Relative links are preferred. It is not recommanded to redirect users to 
github doc from apache doc site. Same as below.



##########
i18n/zh/docusaurus-plugin-content-docs/current/instruction/03-runtime.md:
##########
@@ -1,114 +1,138 @@
 # Eventmesh-runtime 快速入门说明
 
+EventMesh Runtime 是 Apache 
EventMesh(孵化)的核心组件。它是在生产者和消费者之间传输事件的中间件。该文档介绍了在本地或测试环境中安装和启动最新版 EventMesh 
Runtime 的步骤。EventMesh Runtime 需要一个基于 Linux 的系统,并配备 JDK(Java 开发包)8+。

Review Comment:
   Please remove "孵化" characters.
   
   Here is the corrected version:
   ```
   EventMesh Runtime 是 EventMesh 集群中无状态的 Mesh 节点,负责 Source Connector 与 Sink 
Connector 之间的事件传输,并可以使用 EventMesh Storage Plugin 作为事件的存储队列。
   ```
   
   This image is recommanded to be added in 1.10:
   
https://user-images.githubusercontent.com/41445332/262211692-637d24d4-a30b-434e-8da0-25c02ebd6422.png



##########
i18n/zh/docusaurus-plugin-content-docs/current/instruction/00-eclipse.md:
##########
@@ -1,7 +1,5 @@
 # 导入 Eclipse 快速入门说明
 
-我们推荐使用 `Intellij IDEA` 进行开发,如果您希望使用 `Eclipse`,可以参考下面的步骤导入项目。
-

Review Comment:
   This is needed. Please revert it. Most of our developers use IDEA for now.



##########
i18n/zh/docusaurus-plugin-content-docs/current/instruction/03-runtime.md:
##########
@@ -1,114 +1,138 @@
 # Eventmesh-runtime 快速入门说明
 
+EventMesh Runtime 是 Apache 
EventMesh(孵化)的核心组件。它是在生产者和消费者之间传输事件的中间件。该文档介绍了在本地或测试环境中安装和启动最新版 EventMesh 
Runtime 的步骤。EventMesh Runtime 需要一个基于 Linux 的系统,并配备 JDK(Java 开发包)8+。

Review Comment:
   Please remove "孵化" characters.
   
   Here is the corrected version:
   ```
   EventMesh Runtime 是 EventMesh 集群中无状态的 Mesh 节点,负责 Source Connector 与 Sink 
Connector 之间的事件传输,并可以使用 EventMesh Storage Plugin 作为事件的存储队列。
   ```
   
   This image is recommanded to be added in 1.10:
   
https://user-images.githubusercontent.com/41445332/262211692-637d24d4-a30b-434e-8da0-25c02ebd6422.png



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to