yanrongzhen commented on code in PR #4447:
URL: https://github.com/apache/eventmesh/pull/4447#discussion_r1329559002
##########
eventmesh-webhook/eventmesh-webhook-receive/src/main/java/org/apache/eventmesh/webhook/receive/WebHookController.java:
##########
@@ -93,7 +93,7 @@ public void execute(String path, Map<String, String> header,
byte[] body) throws
if (!Objects.equals(webHookConfig.getContentType(),
header.get(CONTENT_TYPE))) {
throw new Exception(
- "http request header content-type value is mismatch. current
value " + header.get(CONTENT_TYPE));
+ "http request header content-type value is mismatch.
current value " + header.get(CONTENT_TYPE));
}
Review Comment:
Because the current alignment length format strategy is 16.
Due to a newline between `throw new Exception (` and `http request xxx`, the
alignment length is 16 (Based on the position of the first letter of `throw`),
but in fact, there should be no newline at the beginning of this string when
coding.
Similar behavior can be found in references such as
**WebHookController.class, line 115**, `WebhookProtocolTransportObject `and
`.cloudEventId`, because it is exactly 16 alignment lengths, no conversion is
triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
