pandaapo commented on code in PR #4442: URL: https://github.com/apache/eventmesh/pull/4442#discussion_r1334943302
########## eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/retry/limiter/SimpleTimeLimiter.java: ########## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.runtime.core.retry.limiter; + +import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.base.Preconditions.checkNotNull; + +import java.lang.reflect.InvocationHandler; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.lang.reflect.Proxy; +import java.util.Set; +import java.util.concurrent.Callable; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; + +import com.google.common.collect.ObjectArrays; +import com.google.common.collect.Sets; +import com.google.common.util.concurrent.UncheckedTimeoutException; +import com.google.common.util.concurrent.Uninterruptibles; + +/** + * A TimeLimiter that runs method calls in the background using an + * {@link ExecutorService}. If the time limit expires for a given method call, + * the thread running the call will be interrupted. + */ +public final class SimpleTimeLimiter implements TimeLimiter { + + private final ExecutorService executor; + + /** + * Constructs a TimeLimiter instance using the given executor service to + * execute proxied method calls. + * <p> + * <b>Warning:</b> using a bounded executor + * may be counterproductive! If the thread pool fills up, any time callers + * spend waiting for a thread may count toward their time limit, and in + * this case the call may even time out before the target method is ever + * invoked. + * + * @param executor the ExecutorService that will execute the method calls on + * the target objects; for example, a {@link + * Executors#newCachedThreadPool()}. + */ + public SimpleTimeLimiter(ExecutorService executor) { + this.executor = checkNotNull(executor); + } + + /** + * Constructs a TimeLimiter instance using a {@link + * Executors#newCachedThreadPool()} to execute proxied method calls. + * + * <p><b>Warning:</b> using a bounded executor may be counterproductive! If + * the thread pool fills up, any time callers spend waiting for a thread may + * count toward their time limit, and in this case the call may even time out + * before the target method is ever invoked. + */ + public SimpleTimeLimiter() { + this(Executors.newCachedThreadPool()); + } + + // TODO: replace with version in common.reflect if and when it's open-sourced Review Comment: What has been deleted? Additionally, from the literal meaning of this "TODO" comment, it seems that there are future tasks that need attention. Could you please explain? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
