mureinik opened a new issue, #4483:
URL: https://github.com/apache/eventmesh/issues/4483

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   Most of the tests in the project were written prior to JUnit 4.13, and use 
some older idioms instead of using the modern `assertThrows`. Following up on 
#4475, JUnit Jupiter offers some more elegant options.
   
   ### Describe the solution you'd like
   
   - There is no need to catch an exception and explicitly fail the test. The 
test should be allowed to throw the exception and error-out, which is 
technically the correct behavior (the test didn't really fail on any logic 
test).
   
   - In order to test cases when an exception must be thrown, 
`Assertions.assertThrows` can be used. There is no need to catch the exception 
assert it is not `null`.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct) *


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to