Pil0tXia commented on code in PR #4384:
URL: https://github.com/apache/eventmesh/pull/4384#discussion_r1368666890
##########
style/checkStyle.xml:
##########
@@ -216,6 +216,12 @@
<message key="name.invalidPattern"
value="Member name ''{0}'' must match pattern ''{1}''."/>
</module>
+ <module name="SuppressionXpathSingleFilter">
+ <property name="id" value="MemberName">
+ <property name="query"
value="//ErrorElement[@sourceName='MemberName'][contains(@message,
'ConfigurationContextUtil.java')
+ or contains(@message, 'JsonUtils.java')
+ or contains(@message,
'RandomStringUtils.java')]"/>
+ </module>
Review Comment:
Exclusions like these are not very friendly to subsequent development and
expansion. This will result in the need to configure the xml file whenever we
need to add a new util class. I would suggest that for utility classes that do
not apply to the `@UtilityClass` annotation, the annotation can be left out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
